Release 3.4.0 broken with Carthage

Question

Release 3.4.0 broken with Carthage

sebskuse opened this issue 3 years ago · comments

Describe the bug

As of the latest release we are unable to build the SDK with Carthage:

[16:55:37]: ▸ Dependency "frames-ios" has no shared framework schemes for any of the platforms: iOS
[16:55:37]: ▸ If you believe this to be an error, please file an issue with the maintainers at https://github.com/checkout/frames-ios/issues/new

It appears that the workspace has moved from the root directory, which means that Carthage is unable to find it.

To Reproduce
Steps to reproduce the behavior:

Add frames-ios as a carthage dependency
Attempt to build dependencies
See error

Expected behavior
The project should build

Harry Brown · Answer 1 · Fri Apr 02 2021 02:37:07 GMT+0800 (China Standard Time)

Hi @sebskuse,
Apologies for the Carthage issue. We are planning to release a patch for this next week. Please use version 3.3.0 until then.

Seb Skuse · Answer 2 · Tue Apr 06 2021 21:35:27 GMT+0800 (China Standard Time)

@harry-brown-cko thanks, let me know if you need any help testing anything pre-release or want to run anything by us.

I notice there is a PR up here #58, although this seems to be for a test project rather than giving this repo a Cartfile (& resolved) and making the project discoverable by Carthage.

Harry Brown · Answer 3 · Tue Apr 06 2021 23:21:48 GMT+0800 (China Standard Time)

Hey @sebskuse, thanks for the heads up. I think we're almost there with the fix now in PR #58. We have tested ourselves and it should now be fine. If you want to double check, point your Cartfile at branch bug/fix-carthage.

Seb Skuse · Answer 4 · Wed Apr 07 2021 04:27:44 GMT+0800 (China Standard Time)

Hi @harry-brown-cko - just given this a go and it looks like it compiles after replacing FramesIos with Frames in our codebase, thanks!

As an aside, as a feature request - it would be great to drop the Alamofire dependency in favour of just using URLSession. Nowadays URLSession is just as powerful, there's less chance of a conflict between other dependencies that may use a different locked version of AF, and it's one less dependency for apps to bundle.

Harry Brown · Answer 5 · Wed Apr 07 2021 04:30:15 GMT+0800 (China Standard Time)

Yeah @sebskuse we agree. This is definitely something we're considering for future releases.

Harry Brown · Answer 6 · Fri Apr 16 2021 16:27:51 GMT+0800 (China Standard Time)

@sebskuse this issue was fixed as part of the latest release, 3.4.1. Please feel free to re-open this if you have any further questions.