Falsely merged a PR
Thorbenl opened this issue · comments
Hey.
First of all, great work with kodiak :) It has been serving us super well.
Sadly today, it merged a pull-request that was not ready yet, since we are relying on CI tests to pass first. Is there any recent events that could have let to that on your side? Our branch protection is on for the branch we are merging into. Settings did not change whatsoever.
Any hint/guidance you can give us to investigate this?
EDIT: We have checked audit logs, but nothing comes up regarded removed brand protection or anything.
@Thorbenl Is this for pull request 9739?
It looks like build_and_test is the only required status check for the develop branch and it looks like build_and_test passed for that PR, so Kodiak was able to merged it.
The GitHub API will prevent Kodiak from merging any PR that does not meet the GitHub Branch Protection requirements.
Nevermind, I was looking at the wrong PR. This is PR 9715.
It looks like the last commit on that PR had a failing check run for build_and_test.
I'm not really sure how Kodiak could even merge the PR if there was a failing check run against the branch protection rules. GitHub shouldn't even allow that to happen.
I haven't been able to replicate this issue an a test repository. I wonder if there was some inconsistency with the GitHub API.
Are you able to reliably replicate this issue?
I haven't been able to replicate this issue an a test repository. I wonder if there was some inconsistency with the GitHub API.
Are you able to reliably replicate this issue?
@chdsbd Sadly no, i cant reproduce it anymore. The audit log is empty too
@Thorbenl I would try opening an issue with GitHub Support because it shouldn't be possible to merge a pull request with a failing status check.