charmbracelet / soft-serve

The mighty, self-hostable Git server for the command line🍦

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

public_url/clone address missing

omenius opened this issue · comments

Describe the bug
The cloning url (public_url) is missing from every view and the 'c' (copy) command is copying nothing.

To Reproduce
On my machine, steps to reproduce:

  1. Install soft-serve 0.7.3 arm64 deb from repo.charm.sh using apt
  2. Add SOFT_SERVE_INITIAL_ADMIN_KEYS to /etc/soft-serve.conf (this is probably irrelevant step)
  3. Enable and start service using systemd with provided /lib/systemd/system/soft-serve.service file
  4. Push some repo(s) in
  5. ssh into the soft-serve TUI, with or without the admin key

Screenshots
issue

Environment (please complete the following information):

  • OS: Armbian (23.11.1)
  • Terminal alacritty/tty
  • Version 0.7.3

Additional information
It doesn't seem to matter which value public_url is set to. I tried with internal ip, external ip, localhost and 'git.example.com'. I've changed them all (ssh, git, http) with no results. I also have external port 22 routed to internal port 23231 with iptables, but surely that is not a part of the problem. Problem is present also when using ssh from localhost (using port 23231).

Systemctl output

Dec 07 16:11:04 odroidc2 systemd[1]: Started soft-serve.service - Soft Serve git server 🍦.
Dec 07 16:11:04 odroidc2 soft[8605]: 2023-12-07 16:11:04 server: Starting Git daemon addr=:9418
Dec 07 16:11:04 odroidc2 soft[8605]: 2023-12-07 16:11:04 server: Starting HTTP server addr=:23232
Dec 07 16:11:04 odroidc2 soft[8605]: 2023-12-07 16:11:04 server: Starting Stats server addr=localhost:23233
Dec 07 16:11:04 odroidc2 soft[8605]: 2023-12-07 16:11:04 server: Starting SSH server addr=:23231

Did I miss something?

For the reference, here is the soft-serve.service file that was shipped with the deb package:

[Unit]
Description=Soft Serve git server 🍦
Documentation=https://github.com/charmbracelet/soft-serve
Requires=network-online.target
After=network-online.target

[Service]
Type=simple
User=soft-serve
Group=soft-serve
Restart=always
RestartSec=1
ExecStart=/usr/bin/soft serve
Environment=SOFT_SERVE_DATA_PATH=/var/lib/soft-serve
EnvironmentFile=-/etc/soft-serve.conf
WorkingDirectory=/var/lib/soft-serve

# Hardening
ReadWritePaths=/var/lib/soft-serve
UMask=0027
NoNewPrivileges=true
LimitNOFILE=1048576
ProtectSystem=strict
ProtectHome=true
PrivateUsers=yes
PrivateTmp=true
PrivateDevices=true
ProtectHostname=true
ProtectClock=true
ProtectKernelTunables=true
ProtectKernelModules=true
ProtectKernelLogs=true
ProtectControlGroups=true
RestrictAddressFamilies=AF_UNIX AF_INET AF_INET6
RestrictNamespaces=true
LockPersonality=true
MemoryDenyWriteExecute=true
RestrictRealtime=true
RestrictSUIDSGID=true
RemoveIPC=true
CapabilityBoundingSet=
AmbientCapabilities=
SystemCallFilter=@system-service
SystemCallFilter=~@privileged @resources
SystemCallArchitectures=native

[Install]
WantedBy=multi-user.target

Hi @omenius, thanks for reporting this. It was fixed in 0a38578 and is now released in v0.7.4