charmbracelet / bubbles

TUI components for Bubble Tea 🫧

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Table's KeyMap does not implement help.KeyMap #872

prgres opened this issue · comments

Describe the bug
A clear and concise description of what the bug is.

In table/table.go is the definition of table.KeyMap:

// KeyMap defines keybindings. It satisfies the help.KeyMap interface, which
// is used to render the menu.
type KeyMap struct {
	LineUp       key.Binding
	LineDown     key.Binding
	PageUp       key.Binding
	PageDown     key.Binding
	HalfPageUp   key.Binding
	HalfPageDown key.Binding
	GotoTop      key.Binding
	GotoBottom   key.Binding
}

The comment above the struct statement that struct satisfying interface but it lacks of method ShortHelp() []key.Binding and FullHelp() [][]key.Binding

Setup
Please complete the following information along with version numbers, if applicable.

  • OS [e.g. Ubuntu, macOS]
  • Shell [e.g. zsh, fish]
  • Terminal Emulator [e.g. kitty, iterm]
  • Terminal Multiplexer [e.g. tmux]
    Irrelevant, since it is the code bug.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error
    table.table.go:40

Source Code
Please include source code if needed to reproduce the behavior.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
Add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

I have addressed this in #440