charliesbot / react-native-media-controls

A sweet UI component to manipulate your media. Strongly typed.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Change react-native-slider dev depedencies

padunk opened this issue · comments

Hi,
Thanks for making this awesome control.
One of the crucial dependency (react-native-slider) seems not maintain anymore.
I keep getting a warning about it.
Is it possible to switch to other package?

@xchwarze because it requires linking the package, and I would prefer to keep this library as simple as possible.

I'll take a look into the slider warnings this weekend.

@charliesbot Hello is there any posibility that will you swap those packages? The "react-native-slider" is the old one, without any further support. Thanks :]

From what I've seen in other screenshots from people that swapped both libraries, it looks a little bit different.

I was planning to upgrade the original library. But if the community already settled down with react-native-slider (which is a different library from a different creator, even if they share a similar API), I'll prefer to work on the upgrade.

Feel free to open a PR with this change + screenshots if you are in a rush.

Otherwise, I can take a look in a couple of days. I changed jobs a couple of weeks ago and most of my time goes into the new gig.

commented

For Expo users we rely on @react-native-community/slider