Line sometimes stays hidden

Question

Line sometimes stays hidden

ronnc opened this issue 4 years ago · comments

https://github.com/DiZhou92/ngx-line-truncation/blob/6423a7b9ac9e70b87160427ce35905cc0a845937/projects/line-truncation-lib/src/lib/line-truncation.directive.ts#L135

Hi there, thanks for the cool library. However, I find that sometimes the element style is still hidden after rendering.

It happens randomly and I don't have a small test case for you but I though it is worth raising it here in case you can see anything obvious.

Could it be possible that clientHeight is <=0 ?

Di Zhou · Answer 1 · Wed Apr 01 2020 15:22:22 GMT+0800 (China Standard Time)

it's hard to say the problem without looking at a specific case, can you provide one?

Di Zhou · Answer 2 · Thu Jun 04 2020 10:04:37 GMT+0800 (China Standard Time)

close because there was no further conversation

Conner Simmons · Answer 3 · Thu Jul 30 2020 23:47:15 GMT+0800 (China Standard Time)

I think I've been able to replicate this issue:

You can see the p tag has text content but also the style is set to hidden still.

Di Zhou · Answer 4 · Fri Jul 31 2020 21:09:10 GMT+0800 (China Standard Time)

Hi Could you provide your issue scenario in a demo project? thanks Regards, Di

…

On Thu, 30 Jul 2020 at 11:47, Conner Simmons ***@***.***> wrote: I think I've been able to replicate this issue: [image: Screen Shot 2020-07-30 at 11 44 15 AM] <https://user-images.githubusercontent.com/7469758/88944047-41242980-d25a-11ea-8867-729f2a522379.png> You can see the p tag has text content but also the style is set to hidden still. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCTI62V2J6I7FJMRO64FLTR6GIZJANCNFSM4LYGS2RQ> .

Conner Simmons · Answer 5 · Tue Aug 04 2020 02:41:31 GMT+0800 (China Standard Time)

@DiZhou92 I've created a StackBlitz with some of the minimum elements from my app to hopefully replicate the issue:
https://stackblitz.com/edit/ionic-dpbvci. I've attached a zip of it as well. Typically the post information is coming from and API, but it was difficult for me to mimic that without giving away some sensitive information.
ionic-dpbvci.zip

Di Zhou · Answer 6 · Thu Aug 06 2020 08:24:47 GMT+0800 (China Standard Time)

Thanks, I will take a look this week.

…

On Mon, 3 Aug 2020 at 14:41, Conner Simmons ***@***.***> wrote: @DiZhou92 <https://github.com/DiZhou92> I've created a StackBlitz with some of the minimum elements from my app to hopefully replicate the issue: https://stackblitz.com/edit/ionic-dpbvci. I've attached a zip of it as well. Typically the post information is coming from and API, but it was difficult for me to mimic that without giving away some sensitive information. ionic-dpbvci.zip <https://github.com/DiZhou92/ngx-line-truncation/files/5017749/ionic-dpbvci.zip> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCTI65AY5L5O6RPAROB6NTR64AGVANCNFSM4LYGS2RQ> .