Update to Angular 9

Question

Update to Angular 9

Enngage opened this issue 4 years ago · comments

Hey,

as title suggest, can you update peer deps for Angular 9? :)

Di Zhou · Answer 1 · Wed Apr 01 2020 17:05:54 GMT+0800 (China Standard Time)

Hey,
I finished the update, everything works fine for projects running the latest Angular. However there is a typescript compatible issue,
storybookjs/storybook#9463
So that means in order to use the new build, users would have to upgrade to typescript 3.7, which is not compatible to Angular 8 and below
Therefore, I'm holding off this upgrade for now till I find a good solution, if you have any suggestion, please let me know!

Richard Sustek · Answer 2 · Wed Apr 01 2020 17:14:46 GMT+0800 (China Standard Time)

Hi, I think you should update this library. Users using older Angular version can use older versions of your package. Angular 8 is already out of active support and its LTS ends quite soon - https://angular.io/guide/releases

Is there really a need to hold on this update? Do old users using angular 8 need to use new versions of this library for angular 9? No matter how I look at it it doesn't make much sense to postpone update.

Di Zhou · Answer 3 · Mon Apr 20 2020 05:18:18 GMT+0800 (China Standard Time)

Hi Enngage,

Thanks for your input, I have updated the dependencies, if there is not issue on your side, I will close this thread.

Regards,
Di

Richard Sustek · Answer 4 · Mon Apr 20 2020 15:27:01 GMT+0800 (China Standard Time)

Yeah, we can close this thread. Thanks!

Richard Sustek · Answer 5 · Wed May 13 2020 15:58:56 GMT+0800 (China Standard Time)

Hi,

sorry, this is not resolved. You haven't updated peer dependencies in your lib here https://github.com/DiZhou92/ngx-line-truncation/blob/master/projects/line-truncation-lib/package.json#L24

This is still giving peer dependency warnings when using with Angular 9

Di Zhou · Answer 6 · Thu May 14 2020 00:53:34 GMT+0800 (China Standard Time)

Oh sorry about that, will get it updated soon. Thank you sir. Regards, Di

…

On Wed, May 13, 2020 at 3:59 AM Richard Sustek ***@***.***> wrote: Reopened #22 <#22>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#22 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCTI64VPUY3TPJB6UP7TBTRRJHM7ANCNFSM4LNE47DQ> .

Di Zhou · Answer 7 · Thu May 14 2020 12:57:35 GMT+0800 (China Standard Time)

Hi Enngage, I just got peer dependency update, let me know if that works for you. Thanks!

Richard Sustek · Answer 8 · Thu May 14 2020 16:33:46 GMT+0800 (China Standard Time)

Hi @DiZhou92 ,

Thank you, but it still isn't quite right :)

You cannot combine both ^ and ~ in peer dependencies. See https://stackoverflow.com/questions/22343224/whats-the-difference-between-tilde-and-caret-in-package-json

You should actually define peer dependencies as:

"@angular/common": "~9.0.0",
 "@angular/core": "~9.0.0"

So that anyone using Angular 9 can install and use your library without unnecessary warning. You are not depending on any specific features released in e.g. 9.1.7 version, so you don't need to specify it.

Di Zhou · Answer 9 · Thu May 14 2020 22:10:52 GMT+0800 (China Standard Time)

Hey i made mistake there, a bit dumb 😅 my apology, was looking for the ~ ^ definition and forget to remove the extra one

Di Zhou · Answer 10 · Thu May 14 2020 22:17:05 GMT+0800 (China Standard Time)

did an update with ^ because i think its ok to be compatible with any V9, let me know!

Richard Sustek · Answer 11 · Fri May 15 2020 16:27:56 GMT+0800 (China Standard Time)

Its ok now, thank you :)

…

On Thu, 14 May 2020 at 16:17, Di Zhou ***@***.***> wrote: did an update with ^ because i think its ok to be compatible with any V9 — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#22 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABWOQR6OHXW5JR26UZQ5O3DRRP4PDANCNFSM4LNE47DQ> .