fix: Add contrast to terminal color with non-default settings

Question

fix: Add contrast to terminal color with non-default settings

alexlokshin-czi opened this issue 3 years ago · comments

@danieljhegeman will provide additional details.

Daniel Hegeman · Answer 1 · Sat Apr 02 2022 07:47:13 GMT+0800 (China Standard Time)

The current iteration of the happy client produces logs in black text. This is a problem for any engineer with a dark terminal background.

Edit: not the case for everyone it seems. Something about my terminal settings is causing the logger to think my background is light, when it's not.

Jessica Gadling · Answer 2 · Tue Apr 05 2022 00:16:40 GMT+0800 (China Standard Time)

I can confirm the same behavior in my terminal - I'm using iterm 3.4.15 with a dark background and the default happy output is using the color I have configured for "bright black" ... which is actually a dark gray and hard to read.

Eduardo Lopez · Answer 3 · Tue Apr 05 2022 00:41:28 GMT+0800 (China Standard Time)

Proposed initial fix: a --no-color and HAPPY_NO_COLOR that will disable colorizing in the CLI.

We can then think of another solution