xsimverb: \l_xsim_file_begin_tl is never expanded since v0.20
muzimuzhi opened this issue · comments
Yukai Chou commented
The following example in package manual, Appendix C was broken by commit 5239682, since the argument of \XSIMsetfilebegin
, which is then stored in \l_xsim_file_begin_tl
, was never expanded before written to a temp file.
Lines 2368 to 2393 in 899c94c
To be consistent with the usages of \l_xsim_file_(begin/end)_tl
in xsim
itself, one possible proposal could be
diff --git a/code/xsimverb.sty b/code/xsimverb.sty
index 2945542..e8ea801 100644
--- a/code/xsimverb.sty
+++ b/code/xsimverb.sty
@@ -294,10 +294,10 @@
{ \xsim_file_write_stop: }
\NewDocumentCommand \XSIMsetfilebegin {+m}
- { \tl_set:Nn \l_xsim_file_begin_tl {#1} }
+ { \tl_set:Nx \l_xsim_file_begin_tl {#1} }
\NewDocumentCommand \XSIMsetfileend {+m}
- { \tl_set:Nn \l_xsim_file_end_tl {#1} }
+ { \tl_set:Nx \l_xsim_file_end_tl {#1} }
\NewDocumentCommand \XSIMgobblechars {m}
{ \int_set:Nn \l_xsim_line_gobble_int {#1} }
Clemens Niederberger commented
Thanks. Fixed by introducing variants that expand their argument first.