cgdecker / vogar

Automatically exported from code.google.com/p/vogar

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Enable --stream automatically for caliper and main targets

GoogleCodeExporter opened this issue · comments

For usability!

Original issue reported on code.google.com by jessewil...@google.com on 24 Apr 2010 at 7:10

maybe in TestRunner.run? add a Runner.shouldStream method, call it for each 
Runner 
and override the user-supplied setting? or do we want --no-stream to turn off 
streaming for Caliper even though that makes no sense? (because in the "main" 
case, 
we've no way of knowing whether or not it makes sense.)

maybe the easiest fix is to just make --stream the default? when is --no-stream 
really useful? especially interactively (which is when you'd care about having 
to 
supply the argument. if it's only for continuous builds, it's no hardship 
because it 
just goes in a script somewhere.)

Original comment by elliott....@gmail.com on 24 Apr 2010 at 7:35

--stream made the default in revision 30.

a bit lame that --no-stream on a caliper benchmark will silently do the wrong 
thing, 
but that seems relatively unlikely. who'd ever use --no-stream anyway?

Original comment by e...@google.com on 26 Apr 2010 at 10:02

Original comment by e...@google.com on 26 Apr 2010 at 10:02

  • Changed state: Fixed