jsdoc issue

[Thomas Wormann]

Hi Chris,

I think you forgot to update your jsdoc on one of your latest changes here:

reef/src/components/render.js

Lines 57 to 64 in 9552836

 /** 
  * Add an attribute to an element 
  * @param {Node}   elem The element 
  * @param {String} att  The attribute 
  * @param {String} val  The value 
  * @param  {Boolean} events If true, inline events are allowed 
  */ 
 function addAttribute (elem, att, val, events) { 

In the jsdoc you reference events as a boolean, later your accessing it as a object:

reef/src/components/render.js

Lines 70 to 73 in 9552836

 if (events && events.delegate) { 
 	events.delegate(elem, att, val); 
 	return; 
 } 

And I think the problem starts at the diffAttribute function, where events is declared as a boolean as well:

reef/src/components/render.js

Lines 103 to 109 in 9552836

 /** 
  * Compare the existing node attributes to the template node attributes and make updates 
  * @param  {Node}    template The new template 
  * @param  {Node}    existing The existing DOM node 
  * @param  {Boolean} events   If true, inline events allowed 
  */ 
 function diffAttributes (template, existing, events) { 

And no jsdoc regarding events here at all:

reef/src/components/render.js

Lines 160 to 164 in 9552836

 /** 
  * Add default attributes to a newly created element 
  * @param  {Node} elem The element 
  */ 
 function addDefaultAtts (elem, events) { 

Cheers,
Thomas

[Chris Ferdinandi]

Good catch, thanks! I'll get that updated soon...

[Chris Ferdinandi]

This was fixed at some point. I forget which version, though, sorry!