Please release a new CocoaPod version
kukushi opened this issue · comments
Description:
-
Expected behaviour:
-
Actual behaviour:
Environment
-
Package Manager:
- Carthage, version:
- CocoaPods, version:
- Manually
-
Fuzi version: 2.1.0
-
Xcode version: 10.2
How to reproduce:
Build with the 10.2
Carthage is also not working, the project is not building. Needs to conforme NodeSet to Sequence. No idea how to do that.
I had to change _precondition to precondition, but that got it building in 4.2 mode.
Also, to build in Swift 5 mode, just two open lets have to be changed to public.
For whoever having issues building on Xcode 10.2, there is a workaround for this.
Install Fuzi in Podfile using this
pod 'Fuzi', :git => 'git@github.com:cezheng/Fuzi.git', :branch => 'master'
Because the latest 2.1.0 tag does not contains the fix of this issue, but master does.
I was going to make a PR helping for the new Swift 5 version, but, looks like with Swift 5 and the modifications already in master there is issues parsing data (few HTML unit tests are failing), so, looks like it's not ready. If someone use the master branch right now for Swift 5, please, check what I said been sure nothing is broken in your environment.
I'm trying to hep with the issues, but I don't know when I can have something.
Thanks for filing the issue. I will probably spend sometime this weekend (pacific time) to fix this, or I will happily review any PR if anyone is already actively working on a fix.