cereal-lab / EvoPIE

Evolutionary Peer Instruction Environment

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bottstrap mix of version 5.1 and 4.5.0

dvitel opened this issue · comments

We should use one of them because they are not backward compatible.
5.1 - does not depend on jquery, has other set of css classes
4.5 - depends on jquery
Problem that could appear - existing code could depend on both of them now
Now, css is taken for 5.1 for grader view (for example) and js from 4.5
Careful investigation is required how change of css or js to one or other version could affect UI/app

<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-1BmE4kWBq78iYhFldvKuhfTAU6auU8tT94WrHftjDbrCEXSU1oBoqyl2QvZ6jIW3" crossorigin="anonymous">

<script src="https://stackpath.bootstrapcdn.com/bootstrap/4.5.0/js/bootstrap.min.js"
integrity="sha384-OgVRvuATP1z7JjHLkuOU7Xw704+h835Lr+6QL9UvYjZE3Ipu6Tp75j7Bh/kR0JKI"
crossorigin="anonymous"></script>

Created this branch for this issue: https://github.com/cereal-lab/EvoPIE/tree/72-bottstrap-mix-of-version-51-and-450
There are 3 separate issued addressing 3 sub-issues.

Done! Merged to master!