cep21 / circuit

An efficient and feature complete Hystrix like Go implementation of the circuit breaker pattern.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Manager.GetCircuit should work on an empty manager

cep21 opened this issue · comments

On an empty manager object, it should return nil

I was looking at issues in this repo to contribute to. Either this isn't an issue any longer or this needs more info. There appears to be a test for this:

func TestManager_Empty(t *testing.T) {
	h := Manager{}
	if h.GetCircuit("does_not_exist") != nil {
		t.Error("found a circuit that does not exist")
	}
}

If I'm misunderstanding the issue and this needs work please let me know.

Hmmm perfect! Thanks for catching this.