StatSender interface signature has changed
7ail opened this issue · comments
Hi there,
Tried configuring the StatSender
in statsdmetrics.CommandFactory{}
and realised the statsdmetrics.StatSender
interface no longer matches the StatSender
interface in go-statsd-client
.
Seems like they've introduced a new variadic parameter for tags at the end
Thanks for the update. I don't think I can change this API to match because it would be a breaking change for users of the library. I recommend maybe a comment at the interface with a recommendation that people implement a custom metrics collector.
We have one for prometheus here. If you want to make one for statsd with the new API, you can reference it and I'll update the docs to point to it as an alternative.
Will close as wontfix for v3 since we cannot break people's code, but will address in v4 here: #115