cenkalti / github-flask

🍾 Flask extension for GitHub API

Home Page:https://github-flask.readthedocs.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Look for configs in os.environ

ehfeng opened this issue · comments

Would be a nice touch to have the app look in the os.environ if app.config doesn't have the client id and and client secret values.

Similar to how FLASK_DEBUG works. I can do the PR—I wanted to open the issue to check if it's in line with how you see this library being used.

Hi @ehfeng. Thanks for asking before sending the PR.

  • Can you tell why do you need this?
  • Is there any Flask extension that you know implement this behavior?

Oh, I don't need this—I can just os.environ.get. It just seemed convenient, as Flask itself pulls some configs from the environment.