cenkalti / github-flask

🍾 Flask extension for GitHub API

Home Page:https://github-flask.readthedocs.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Get requests does not pass on query parameters

rhblind opened this issue · comments

Hi,

In the get() shortcut method, the params kwarg is not passed on to the self.request metod.

Is this by design?

When doing a query like this, I'd expect my parameters to be passed on to the Github API.

    def get(self):
        repo_dict = github.get('user/repos', params={'type': 'private'})
        return repo_dict

This way I should only receive my private repositories

No, this is a bug. Can you send a PR?

Sure

On Fri, Sep 23, 2016, 08:44 Cenk Altı notifications@github.com wrote:

No, this is a bug. Can you send a PR?


You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub
#35 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABgFlzyr5kfz8-VNB9HN_A-w8_3dUZIBks5qs3VIgaJpZM4KEaoh
.

Rolf Håvard Blindheim
rhblind@gmail