cemerick / friend

An extensible authentication and authorization library for Clojure Ring web applications and services.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Dependency issue with robert-hooke

kendagriff opened this issue · comments

I didn't know where else to report this (perhaps it will help someone else), but I'm working on an app where one of my dependencies requires robert-hooke, version 1.3.0. That friend requires 1.1.2 prevented me from firing up my repl correctly:

#<ArityException clojure.lang.ArityException: Wrong number of args (3) passed to: hooke$add-hook>

Apparently in version 1.1.2 add-hook received two arguments, and now in 1.3.0, it takes three.

The fix, for me, was to include [robert/hooke "1.3.0"] to my list of dependencies, along with friend.

We should be able to upgrade this without much blowback.

It looks like add-hook in 1.3.0 takes two and three arguments:

https://github.com/technomancy/robert-hooke/blob/master/src/robert/hooke.clj#L93

In any case, friend itself doesn't use hooke, but its tests do. So, the dependency on it has been moved to the :dev profile.