Warning: PO::export_entry(): Argument #1 ($entry) must be passed by reference

Question

Warning: PO::export_entry(): Argument #1 ($entry) must be passed by reference

JJJ opened this issue 4 years ago · comments

PHP8 appears to trigger the following warning:

Warning: PO::export_entry(): Argument #1 ($entry) must be passed by reference, value given in /node_modules/.pnpm/node-wp-i18n@1.2.3/node_modules/node-wp-i18n/bin/php/pomo/po.php on line 52

Brady Vercher · Answer 1 · Wed Dec 02 2020 04:23:18 GMT+0800 (China Standard Time)

Hi @JJJ! I don't have a way to test this at the moment. Would you be willing to submit a PR or test?

I don't see why that argument needs to be passed by reference, so it might just be as simple as removing the &.

Brady Vercher · Answer 2 · Thu Feb 04 2021 01:26:26 GMT+0800 (China Standard Time)

I believe this should be good to go in 03b5c05