ModelFile does not fully support NodeSet syntax
degremont opened this issue · comments
In .lmf files, the node argument of "client:" lines does not fully support the NodeSet syntax. Minor problem but the error reported is confusing.
Example of unsupported configuration:
client: node=lu01,lu20
Error: Configuration - Cannot get NID for lu01,lu20, aborting. Please verify 'nid_map' configuration.
Example of supported configuration:
client: node=lu[01,20]
Indeed, in ModelFile, only RangeSet are expanded and in Configuration/FileSystem.py, Clients.get_nodes() passes the argument as is. NodeSet should be used somewhere. I guess each node-like argument should be casted to NodeSet when the lmf is read, so perhaps it could make sense to do it in ModelFile.
There is probably the same problem with "target:" and "router:" node arguments.
Reported by: sthiell
Thanks for reporting this.
Even if this could be slightly improved supporting comma, it is tricky to fully supports real NodeSet syntax.
What about:
client: node=lu01,lu20 mount_path=/mnt/lu[01-02]
Have a look at Shine.Configuration.ModelFile.MultipleElement.parse()
Original comment by: degremont
- Milestone: 1.5 --> 1.6
Original comment by: degremont