update should detect updated targets
degremont opened this issue · comments
When a user updates a model file, and change some Targets options, update command will not detect it as a target updates, but a target removal + a target addition. This will lead to format proposal, etc.
This should be correctly detected
Reported by: degremont
- status: open --> closed
- Resolution: --> fixed
- Version: --> 1.3.1
Original comment by: degremont
Fix in [0bc2e7]
Original comment by: degremont
Please find an add-on to this patch at the following location:
bullxpfs/lustre-shine@2900739
This commit helps detect which fields have been changed in an updated target or client, and allows to trigger appropriate actions based on these changes.
Regards.
Original comment by: theryf
Please find a new patch based on your comments on previous one:
bullxpfs/lustre-shine@113f22a
This one is not a definitive one as I did not have enough time to update unit tests for the new data structure.
Thanks
Original comment by: theryf
Please find yet another patch based on your latest comments and remarks
and on the snippet you sent me by email:
bullxpfs/lustre-shine@204e9a5
Unit tests are updated as well.
Thanks
Original comment by: theryf
Please find another patch based on you minor comments on previous one.
bullxpfs/lustre-shine@f3c7f01
Thanks
Original comment by: theryf
I've fixed few details in this patch pushed it in [89dae5].
This ticket is really closed now!
Original comment by: degremont