Adding progressbar on contributors list screen

Question

Adding progressbar on contributors list screen

cdhiraj40 opened this issue 2 years ago · comments

Is your feature request related to a problem? Please describe.
Currently, there is no progress bar for the contributor list screen, which makes the experience bad for the user. It would be great to have a progress bar there. Make sure that you are using the same progress bar(loading view) on the screen which is used for most of the screens.

Describe the solution you'd like
This one should be an easy issue to solve, all you have to do is just check out the implementation of the progress bar on different screens. You can find it here for question screen

Steps:

Show the loading view at the start of the screen
Hide it once the contributor list has been fetched

Describe alternatives you've considered
None

Additional context
You can ping me in the comments if additional information is needed!

Sanjay Sargam · Answer 1 · Sun Oct 23 2022 00:11:37 GMT+0800 (China Standard Time)

Could you tell me exactly which activity?

Dhiraj Chauhan · Answer 2 · Tue Oct 25 2022 00:28:24 GMT+0800 (China Standard Time)

Could you tell me exactly which activity?

yes sure! You can find the code for contributors list here: https://github.com/cdhiraj40/LeetDroid/blob/development/app/src/main/java/com/cdhiraj40/leetdroid/ui/fragments/preferences/ContributorsFragment.kt

@SanjaySargam would you like to work on this?

Sanjay Sargam · Answer 3 · Tue Oct 25 2022 00:46:18 GMT+0800 (China Standard Time)

Could you tell me exactly which activity?

yes sure! You can find the code for contributors list here: https://github.com/cdhiraj40/LeetDroid/blob/development/app/src/main/java/com/cdhiraj40/leetdroid/ui/fragments/preferences/ContributorsFragment.kt

@SanjaySargam would you like to work on this?

Yess

Sanjay Sargam · Answer 4 · Tue Oct 25 2022 02:28:41 GMT+0800 (China Standard Time)

@cdhiraj40 where the ContributorsFragment Activity used in the app?
I can't able to find

Dhiraj Chauhan · Answer 5 · Tue Oct 25 2022 02:30:37 GMT+0800 (China Standard Time)

@cdhiraj40 where is the ContributorsFragment Activity used in the app?
I can't able to find

You can ctrl + click on the class name and it will show you where it is getting used.

Sanjay Sargam · Answer 6 · Tue Oct 25 2022 02:35:02 GMT+0800 (China Standard Time)

@cdhiraj40 where is the ContributorsFragment Activity used in the app?
I can't able to find

You can ctrl + click on the class name and it will show you where it is getting used.

Yah I know. I find the files. But didn't find where exactly this activity used in app

Dhiraj Chauhan · Answer 7 · Tue Oct 25 2022 02:43:01 GMT+0800 (China Standard Time)

@cdhiraj40 where is the ContributorsFragment Activity used in the app?
I can't able to find

You can ctrl + click on the class name and it will show you where it is getting used.

Yah I know. I find the files. But didn't find where exactly this activity used in app

Left Menu -> About -> Contributors

Sanjay Sargam · Answer 8 · Tue Oct 25 2022 02:57:39 GMT+0800 (China Standard Time)

@cdhiraj40 where is the ContributorsFragment Activity used in the app?
I can't able to find

You can ctrl + click on the class name and it will show you where it is getting used.

Yah I know. I find the files. But didn't find where exactly this activity used in app

Left Menu -> About -> Contributors

Yahh finally got it. 😅😅

Sanjay Sargam · Answer 9 · Tue Oct 25 2022 03:03:46 GMT+0800 (China Standard Time)

is there any need to add error_loading_view?

Dhiraj Chauhan · Answer 10 · Tue Oct 25 2022 03:06:34 GMT+0800 (China Standard Time)

is there any need to add error_loading_view?

yes add it, just like other screens if something goes wrong while fetching the contributors

Sanjay Sargam · Answer 11 · Tue Oct 25 2022 03:07:43 GMT+0800 (China Standard Time)

is there any need to add error_loading_view?

yes add it, just like other screens if something goes wrong while fetching the contributors

Okk cool