cdfmlr / pyflowchart

Python codes to Flowcharts

Home Page:https://pypi.org/project/pyflowchart/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ConditionNode alignment support

angerhang opened this issue · comments

Thank you a lot for the package. It is really useful for one of my use cases in work :D

As raised in this issue, adrai/flowchart.js#221, it would be great to allow the align-text option set for the condition node. It should be something easy to do to set a positional argument in the constructor for the ConditionNode(name, isAlign=True).

Can this be added quickly? If not, we can maybe do a PR if you point out the caveats :D

Thought it we need to modify these two definitions?

class ConditionNode(Node):
def fc_definition(self) -> str:

A great feature.

However I am in my vacation now. So I can not work on it until this weekend. If you need it urgently, please feel free to make a PR.

Thanks for the quick reply :D

It is not that urgent haha you probably can do it much faster than me. I will try take a look in the next days. If I don't mange, then it would be great if you can add this in.

Enjoy your vacation! @cdfmlr

@angerhang I guess I have made it in 35487f9, basically. You can check to try it now. But I'll merge and release it later, after further tests.

I believe this feature is fully supported in the latest v0.2.3 release.

You can upgrade and use it. See README or release notes for docs.

pip install pyflowchart==0.2.3

Reopen this issue if there are any related problems.

Thank you so much!