:CMakeToggle

Question

:CMakeToggle

sillydan1 opened this issue 2 years ago · comments

Asger Gitz-Johansen commented 2 years ago

Since we already have :CMakeOpen and :CMakeClose it feels like it would be appropriate with a :CMakeToggle command that toggles the cmake window.

This could be manually scripted in users' init script file(s), but it would be much cleaner and easier to keybind if it was a built-in feature of the plugin.

Carlo Delle Donne · Answer 1 · Tue May 02 2023 23:43:42 GMT+0800 (China Standard Time)

Hi, thanks for opening this.

I think your request makes sense, and should be fairly easy to implement. Would you be interested in submitting a PR?

Asger Gitz-Johansen · Answer 2 · Wed May 03 2023 02:01:29 GMT+0800 (China Standard Time)

I am not very well versed in vimscript but I'll give it a shot. Maybe some time this weekend 👍

Asger Gitz-Johansen · Answer 3 · Wed Nov 01 2023 14:23:12 GMT+0800 (China Standard Time)

Thanks for merging! I'll be honest, I had completely forgot about the PR 😄

Carlo Delle Donne · Answer 4 · Wed Nov 01 2023 18:20:07 GMT+0800 (China Standard Time)

I understand :) I didn't want to be pushy so I just finalized it myself. Thanks for the contribution!