cc-archive / vocabulary-legacy

A cohesive design system & Vue component library to unify the web-facing Creative Commons

Home Page:https://cc-vocabulary.netlify.app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bug: Height of docs story in Patterns > Locale > Modal is small and Modal is getting hidden

darkshredder opened this issue · comments

Description

Height of docs story in Patterns > Locale > Modal is small and the Modal is getting hidden

Reproduction

  1. Go to the following url Modal
    2.You can see modal is not clearly shown in docs page

Expectation

Screenshot from 2021-02-21 20-38-09

Screenshots

Screenshot from 2021-02-21 20-38-52

Resolution

  • I would be interested in resolving this bug.

@darkshredder On Chrome and Edge:
image

@darkshredder interesting observation! On firefox, it does seem to act funny. Any idea how you'd go about solving this?

@nimishbongale I tried on chrome its showing as in @Yashs911 image now without any changes and show code is also not working in chrome. With the changes done by me by adding height property to element now its showing as per expectation image posted by me on both chrome and firefox.

Chrome after changes

Screenshot from 2021-02-21 20-58-43

Firefox after changes

Screenshot from 2021-02-21 20-38-09

@nimishbongale Can I raise PR for the same issue?

@nimishbongale Can I raise PR for the same issue?

Go ahead @darkshredder! 👍

Stale issue message