valgrind checks in CI
tisaac opened this issue · comments
Description
Memory leaks can be integrated into releases and development branches silently right now
Proposed solution
Add a CI runner that configures the test environment to run with valgrind.
Would you want to add a PR to this and/or coordinate with @gghosh8495 working on our CI?
It's proposed on branch feature-test-valgrind. I'd be happpy for comments.
The CI takes a really long time then. Thoughts?
We could take the valgrind CI out again and you may run configure --enable-valgrind on your end as needed?
Now removing debug mode and optimizing with -O2 brings the runtime down to under 20 minutes.
This may be sufficient for github. Anybody is free to test their configuration using --enable-valgrind.
@cburstedde The valgrind test for CMake is trivial. CTest has in-built option to run valgrind in tests. I will update the documentation.
@cburstedde The valgrind test for CMake is trivial. CTest has in-built option to run valgrind in tests. I will update the documentation.
Thanks. Would it make sense to add such a job to ci_valgrind.yml?
@cburstedde Yes, I will update the file.
So we have CI valgrind testing now.
To keep run times acceptable, we are using -O2 on the valgrind compile.
Occasionally we see p8est_is_balanced throw a valgrind error, and we have eliminated p8est_test_balanced from the valgrind CI run. This would need to be investigated.