Why is there `module-info.java`?
mkoncek opened this issue · comments
I am packaging this project and noticed this file outside of java source tree. Is it supposed to be added manually or not?
If not, is there a reason why it is present in the project at all? I see that currently released jars are not modular.
In any case even the module-info.java
seems to be incomplete as I got the following errors when I attempted to build the project with the file added into the java source tree:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project jcommander: Compilation failure: Compilation failure:
[ERROR] /builddir/build/BUILD/beust-jcommander-1.82/src/main/java/com/beust/jcommander/Parameterized.java:[11,17] package java.util.logging is not visible
[ERROR] (package java.util.logging is declared in module java.logging, but module com.beust.jcommander does not read it)
[ERROR] /builddir/build/BUILD/beust-jcommander-1.82/src/main/java/com/beust/jcommander/Parameterized.java:[12,17] package java.util.logging is not visible
[ERROR] (package java.util.logging is declared in module java.logging, but module com.beust.jcommander does not read it)
I just want to point out that the current situation creates confusion for others as to whether or not module-info.java
should be used.
@mkoncek Feel free to provide a PR to resolve this issue. :-)