Allow for configuration overrides / replacement
repraze opened this issue · comments
I'm looking to add support for peacock and previously created a repo for it to allow for the user to change favorite colors.
Currently this vscode theme only allow for extensions to swap out color contributions from vscode extensions. However peacock does not contribute any colors to the vscode theme and favorites colors are a configuration contribution.
The type generation only allows for contributes.colors to be extracted and changed. I'm not sure what the best solution is here to allow for contributes.configuration.properties.favoriteColors to be changed/edited when changing the theme.
I'm not sure if this means the property is not themable in this case. If this cannot be supported, please reopen the original issue.
I'm not really familiar with VSCode Peacock, looking at the theme files in your repo, it looks like those are settings.json values intended for use with Peacock installed and activated instead of Catppuccin? In that case, we could probably use https://code.visualstudio.com/api/references/contribution-points#contributes.configurationDefaults 🤔