PHP Syntax highlighting issues

[Miguel da Mota]

Hi there, I found some issues for PHP:

1. Variables inside of a string don't look right. If it's intentional it's fine with me (it's just looking weird 😅)

---

2. PHP built-in functions like echo or isset aren't highlighted differently as before (v2.9.0)

• Now

• Before

---

3. Opening and closing tag are inconsistent

For me, these are minor issues but I just want to point them out 😄

Have a great day!

[winston]

Thanks for reporting those, I'll have a look at 1 & 3, but 2 seems intentional to me, as blue is used for functions elsewhere; which color would you expect there?

[Miguel da Mota]

Hi @nekowinston, thank you. For 2, I thought about a light blue (like before) because it's built-in and not a custom function

[winston]

1. Fixed with #190
2. Fixed with #193
3. I can't reproduce that one unless I have invalid Syntax, I can't tell what's happening for you from your ?><?php snippet alone.

[Miguel da Mota]

Thank you so much!

For 3, I am always getting this when I close a php tag. I can only give you more screenshots but I don't know if this helps