cashapp / misk

Microservice Kontainer

Home Page:https://cashapp.github.io/misk/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Emit useful gRPC result metrics

ewolak-sq opened this issue · comments

Misk's default metrics, namely http_request_latency_ms (by action, caller, status code) are HTTP-centric. For gRPC responses, we should probably emit some gRPC-specific metrics, especially because HTTP status code in gRPC is strange (see #1983). https://github.com/grpc-ecosystem/java-grpc-prometheus might be a good place to start.