carvel-dev / kapp

kapp is a simple deployment tool focused on the concept of "Kubernetes application" — a set of resources with the same label

Home Page:https://carvel.dev/kapp

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

kapp gets confused when ordering of fields isn't deterministic

voor opened this issue · comments

What steps did you take:
Some custom resources, like for example AWSCluster in Cluster API AWS, do not guarantee consistent ordering of entries. This causes kapp to fail in validating whether something truly needs to be updated.

What happened:
Given an array:

1
2
3

if that array is somehow changed in order:

3
2
1

then kapp will believe that the array has changed, and make updates accordingly.

What did you expect:
Since array ordering is actually a modification, this issue might be very difficult to truly tackle, so I reckon kapp thinking the object has changed is the intended result.

Anything else you would like to add:
Maybe the real problem here is that there needs to be a rebase rule to say an array's ordering isn't important, which would be nondefault behavior?

Environment:

  • kapp version (use kapp --version):
  • OS (e.g. from /etc/os-release):
  • Kubernetes version (use kubectl version)

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

Closing this issue as it's fairly stale and unique to that given scenario.