Custom waitRules should work with default waiting rules of other resources like deployments
praveenrewar opened this issue · comments
Describe the problem/challenge you have
When I provide a custom waitRule for resources like Deployment, ReplicaSet, etc,. then the default waiting behaviour provided by kapp doesn't work. This is because we return early when a custom waiting resource is found.
Describe the solution you'd like
The default waiting rules should work well with custom waiting rules. It would be interesting to figure out which one should have more precedence when both specify the same condition.
Anything else you would like to add:
Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.
Currently Custom waitRules are triggered only after waitRules for app cr, package cr and package repo, ideally we would want to be able to use custom wait rules for these resources too.