cartalyst / tags

A Tagging package that easily allows you to add tags to your Eloquent models.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The typing added to setSlugGenerator now prevents it from accepting a closure.

jshannon63 opened this issue · comments

Your Environment

  • OS and Version: Mac Catalina
  • PHP Version: 7.2
  • Tags Version: 9.0.*

Expected behaviour

setSlugGenerator is documented to accept a closure as an argument. We were using it like this until the latest upgrade to Laravel 6.x and Tags 9.0.

Actual behaviour

setSlugGenerator now requires a string and therefor no longer accepts a closure. We have since updated our code to comply with this, but your docs will need updating if this was your intention.

Steps to reproduce

If your issue requires any specific steps to reproduce, please outline them here.

Sorry, will address it shortly.

Should be fixed on both 9.x and 10.x versions.