New Sabnzbd alert icon?
seanvree opened this issue · comments
OS: Windows 10
Sabnzbd
Agent: Mattermost
Sab Notification script:
mmosts://sabnzbd@mydomain.com/ifeaht4hpxxxxxxxijxdpwfia8ih?verify=False
Issue:
Out of no where the icon that started to display for Sabnzbd is different. And it's being loaded from an insecure source See screenshot below:
Hi,
Yeah; don't panic. I'll try to revert it back to the old icons for SABnzbd this weekend.
I did some major refactoring to the notification application (almost 4000 lines of code removed). I put all of the notification core functionality into it's own library called Apprise that anyone can use (for their own application). So then I updated this script to reference this new (apprise) library instead.
I didn't think about the SABnzbd icons (that's all that changed). Nothing should have broke on you otherwise though?
@caronc Yeah, I figured you were messing with something. no biggie.
Nope, everything works fine!
@caronc I'm getting these errors now:
Notification script returned exit code 1 and output "Traceback (most recent call last):
File "C:\Program Files\SABnzbd\scripts\Notify.py", line 350, in <module>
from nzbget import SCRIPT_MODE
File "C:\Program Files\SABnzbd\scripts\Notify\nzbget\__init__.py", line 23, in <module>
from .ScriptBase import *
File "C:\Program Files\SABnzbd\scripts\Notify\nzbget\ScriptBase.py", line 2504
except TypeError
^
Have another go at it. (fixed it here)
@caronc yeah, that worked. Still have the old icon tho.
I apologize for leaving this ticket for so long. Just to let you know i haven't forgotten about it/you yet. Hopefully I'll have time to fix the icons this week.
@caronc all good brother. First world problems.
The icon looks similar to what it already is, but since it's a standalone notification service, i just gave it an nzb-notify custom icon. They'll look as follows (a variety of sizes depending on the notification service used):
Success Messages
Failure Messages
Info Messages
Warning Messages
Sound okay?
@caronc love it man! Great idea!
TBH, I'm mostly concerned that the images are served from a secure source. Can they not be served from the local repo?
Some notification services that support images can only display them via URL. Others are file based and can read the local ones shipped. If you're concerned about privacy, you can turn off the image display. Alternatively, to address your concern about an insecure source, perhaps I could get the images to look back at the GitHub Repository instead of nuxref.com one?
Yeah there's no point in serving the images from a remote source. Just put them in the repo.
If you wouldn't mind, giver another go. If it works i'll update apprise (the core module) to also source images from GitHub too instead of my nuxref.com host (it's one less thing for me to manage).
Thanks for all your feedback
Looks good @caronc Thanks brotha!