Gradle Plugin V3
augustearth opened this issue · comments
The Gradle plugin carnival-grade is mostly obsolete in V3. The only part that might still be useful is the addition of dependencies that is done by CarnivalLibraryPlugin. CarnivalApplicationPlugin can probably be removed entirely. CarnivalLibraryPlugin can be renamed to CarnivalPlugin and just do the dependency stuff.
Related to the plugin are the references to carnival.home in the code. They are mostly gone, but should be removed entirely.
Similarly, references to logback.configurationFile in the top level build.gradle should also be reconsidered. They should probably stay, but should be reviewed.
Tasks
- Move
logback.configurationFilestuff fromCarnivalApplicationPlugin.groovyto the demo appbuild.gradle - #121
- Rename
CarnivalLibraryPlugintoCarnivalPlugin - Remove all mentions of
carnival.home
logback.configurationFile
- is passed through to sub-project test tasks in
build.gradle - in
CarnivalApplicationPlugin, file is sought in the app home directory. if found, passed to project.run and project.test environments
What's happening in build.gradle makes sense.... We want the log settings to propagate when running Carnival tests.
What's happening in the Carnival application plugin can be done by client application code. We should add something to the demonstration app to show how it could work with Micronaut apps.
This is done. CarnivalLibraryPlugin and CarnivalApplicationPlugin both still exist, but only CarnivalLibraryPlugin is used to create the plugin which is now just called 'carnival'.