carbon-language / carbon-lang

Carbon Language's main repository: documents, design, implementation, and related tools. (NOTE: Carbon Language is experimental; see README)

Home Page:https://github.com/carbon-language/carbon-lang/blob/trunk/README.md

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove clangd BUILD patch

jonmeow opened this issue · comments

#3112 patched the LLVM build to expose files from clangd, here. If possible, this should be upstreamed: we should be trying to stay as close to LLVM upstream as we can, avoiding patches which we would need to maintain.

If it can't be upstreamed because upstream doesn't want these files used as a library, the dependency should be re-evaluated. In general we don't want to add dependencies on internal libraries, because of a lack of long-term stability guarantees.

FYI @josh11b @Maan2003