Giters

capnproto / go-capnp

Cap'n Proto library and code generator for Go

Home Page:https://capnproto.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Benchmark failure

zenhack opened this issue · comments

commented 
$ go test -bench .
goos: linux
goarch: amd64
pkg: capnproto.org/go/capnp/v3/rpc
cpu: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
BenchmarkPingPong-8   	--- FAIL: BenchmarkPingPong-8
    level0_test.go:2077: conn error: rpc: send release: send message: transport: stream transport: send: context canceled
    level0_test.go:2077: conn error: rpc: remote abort: connection closed
    level0_test.go:2077: conn error: rpc: send release: send message: transport: stream transport: send: context canceled
    level0_test.go:2077: conn error: rpc: remote abort: connection closed
    level0_test.go:2077: conn error: rpc: send release: send message: transport: stream transport: send: context canceled
    level0_test.go:2077: conn error: rpc: remote abort: connection closed
    level0_test.go:2077: conn error: rpc: incoming call: answer ID 0 reused
    level0_test.go:2077: conn error: rpc: remote abort: rpc: incoming call: answer ID 0 reused
    bench_test.go:48: call failed on iteration 43774: test.capnp:PingPong.echoNum: rpc: connection closed
FAIL
exit status 1
FAIL	capnproto.org/go/capnp/v3/rpc	0.962s

Haven't started debugging yet. It occurs to me that CI doesn't run the benchmarks, but it probably should just to make sure they pass -- it won't give us super useful data since I don't think github actions is perf isolated enough, but it is not really surprising to me that the benchmarks are broken.

commented

(This doesn't happen every time, but it doesn't take many tries to reproduce)