Giters

capnproto / go-capnp

Cap'n Proto library and code generator for Go

Home Page:https://capnproto.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix issues flagged by goreportcard

lthibault opened this issue · comments

commented

I just had a look at our Go Report Card and noticed a handful of code-quality issues that should be quick to fix. I am creating this issue to track them, and will submit a PR shortly.

Checklist

  • pointer_test.go, line 1: file not gofmted with -s
  • Ineffassign of err in rpc/rpc.go
    • Line 1372
    • Line 1378
    • Line 1391
  • Misspellings
    • internal/mpsc/mpsc_test.go: Lines 69 & 114: s/Recieved/Received
    • message.go: Line 113: s/Analagous/Analogous
    • rpc/export.go: Line 191: s/capabiltiy/capability
    • rpc/rpc.go
      • Line 1160 & 1164: s/capabiltiy/capability
      • Line 1211: s/becasue/because
      • Line 1222: s/embargos/embargoes
commented

Is there some way we can integrate this into CI (maybe by integrating the underlying linters)?

Also, I noticed that the badge in the README isn't a link to the report card, it's a link to... the image of the badge...

commented

Is there some way we can integrate this into CI (maybe by integrating the underlying linters)?

Not sure offhand, but agree this would be helpful.

Also, I noticed that the badge in the README isn't a link to the report card, it's a link to... the image of the badge...

I noticed this as well, but I think the image is dynamically updated based on the state of the report card. I'll double-check.

commented

Badge in README is fixed.