rxjava2

Question

andreya108 opened this issue 8 years ago · comments

Hi!

Will you update your lib for RxJava 2?

Done!

Thanks!

Adam Cantrowitz · Answer 1 · Tue Nov 08 2016 01:31:32 GMT+0800 (China Standard Time)

accepting pull requests!

Adam Cantrowitz · Answer 2 · Tue Nov 08 2016 03:50:31 GMT+0800 (China Standard Time)

pending #9 completes CI pass. Will merge when done.

Andrey Alekseenko · Answer 3 · Tue Nov 08 2016 03:58:11 GMT+0800 (China Standard Time)

Just noticed, I forgot to change README.md.
When new lib will be available in global repos?

Adam Cantrowitz · Answer 4 · Tue Nov 08 2016 04:18:54 GMT+0800 (China Standard Time)

I have updated and released. It should be there in a few hours or so

Andrey Alekseenko · Answer 5 · Tue Nov 08 2016 12:12:41 GMT+0800 (China Standard Time)

Thanks!

In README.md in Unregistering section:
Disposable is returned on subscribe() instead of Subscription in RxJava2:

Disposable disposable = RxBroadcast.fromLocalBroadcast(context, intentFilter).subscribe(...);
...

  protected void onStop() {
    super.onStop();

    if (disposable != null) {
      disposable.dispose();
    }
  }