0.5.0 release

Question

0.5.0 release

akdor1154 opened this issue 3 years ago · comments

Hey guys,
I think i just got unlucky and pulled this at the wrong hour, but it looks like something is funny with the 0.5.0 release.
Crates.io was published 9 days ago, but the Cargo.toml only got bumped to 0.5.0 today, and deps of crate are older than deps in the commit containing 0.5.0 version bump.

Ben Kirwin · Answer 1 · Sat Oct 30 2021 23:29:35 GMT+0800 (China Standard Time)

I suspect this is my fault... I did the 0.5.0 release, and it looks like I failed to push the actual version-bump commit up to the main repository. Apologies! (The 0.5.0 release is commit b5a0ea1 plus a one-line Cargo.toml change, if that helps any.)

Does this cause issues for you in practice?

Ben Kirwin · Answer 2 · Sat Oct 30 2021 23:35:00 GMT+0800 (China Standard Time)

Also here's the tag: https://github.com/canselcik/libremarkable/releases/tag/0.5.0

Jarrad Whitaker · Answer 3 · Sun Oct 31 2021 08:17:20 GMT+0800 (China Standard Time)

Ah ta. No not directly -it seemed like it at the time, but i was looking to fix some dep issues and the release vs. repo state was just a red herring. Thanks for your work on this project :)

Ben Kirwin · Answer 4 · Mon Nov 01 2021 07:08:57 GMT+0800 (China Standard Time)

Aight, I've now merged so that this commit is visible on the master branch. (It sounds like it's not causing issues, but hopefully that will avoid more confusion.) Thanks for checking in!