Giters

canboat / canboat

CAN Boat provides NMEA 2000 and NMEA 0183 utilities. It contains a NMEA 2000 PGN decoder and can read and write N2K messages. It is not meant as an end-user tool but as a discovery mechanism for delving into NMEA 2000 networks.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Latest pgns.xml missing 'Type' for some fields

sbender9 opened this issue · comments

commented

Sorry, I tried to figure out why, but no luck...

Date and Time Type missing here. Might be others types too, tons of stuff broken in canboatjs with latest pgns.json.

DEBUG 2023-03-24T21:10:04.713Z [analyzer-explain] PGN 129033 len=8
      <Length>8</Length>
      <Fields>
        <Field>
          <Order>1</Order>
          <Id>date</Id>
          <Name>Date</Name>
          <BitLength>16</BitLength>
          <BitOffset>0</BitOffset>
          <BitStart>0</BitStart>
          <Units>d</Units>
          <Resolution>1</Resolution>
          <Signed>false</Signed>
          <RangeMin>0</RangeMin>
          <RangeMax>65533</RangeMax>
        </Field>
        <Field>
          <Order>2</Order>
          <Id>time</Id>
          <Name>Time</Name>
          <Description>Seconds since midnight</Description>
          <BitLength>32</BitLength>
          <BitOffset>16</BitOffset>
          <BitStart>0</BitStart>
          <Units>s</Units>
          <Resolution>0.0001</Resolution>
          <Signed>false</Signed>
          <RangeMin>0</RangeMin>
          <RangeMax>86402</RangeMax>
        </Field>
commented

Let’s add a test so this can’t happen again.

commented

Also "Discrete Status 1" missing type for pgn 127489