`humane-are.core-test` suggestions
vemv opened this issue · comments
Hi! Great-looking lib, I'm a heavy are
r myself.
A couple suggestions for increasing my confidence in it:
- In
t/deftest are-test
, you can also assert(is (= x (macroexpand ,,,)))
i.e. set expectations for what the macroexpansions should be - You can assert that no false positives are raised
- placing
is
somewhere deeply nested (vs. top-level) is ok. - top-level
testing
is OK if it has atrue
at tail position.- this is a pattern that clj-kondo and Eastwood understand.
- this allows for custom
testing
strings that are not simply the arguments already provided byare+
- placing
Hope it helps!
Cheers - V
I lack the bandwidth these days, sorry!