Doesn't work with newest jQuery version
energyuser opened this issue · comments
I've asked the same question on jQuery's repo:
jquery/jquery#2460
Hi @energyuser,
Plax has been on the backburner for the last few years, so I won't likely be able to make updates any time soon. If you'd like to submit a pull request fixing the issue, I'm happy to review it.
Sorry, I'm not that good in javascript. I hoped that you could update it but oh well...
Sorry, I can't be of more help at the moment :(. To be honest, Plax is pretty old. I'm willing to bet there are better plugins out there. http://markdalgleish.com/projects/stellar.js/ looks interesting.
It's possible this can be fixed by changing plaxActivityTarget = $(window) to plaxActivityTarget = $(document.body) but I'm not familiar enough with the code to test that hypothesis.
Is this code still being used at GitHub? If so we'd want to be sure we didn't break it with a jQuery update. 😈
Ha, looks as though it is. Guess I should prioritize this after all. Thanks @dmethvin I'll have a look at your suggestion.
Thanks guys! I hope you come up with something and @dmethvin yes: https://github.com/404 Also, when I replaced that code it worked! @cameronmcefee but to make it work I had to defer="defer" my script and the other one that activates plax.
@energyuser for your info, I may not be able to get to this for a few days (things are pretty busy on my end). If you're in a time crunch, I'd suggest looking at alternative plugins or trying to fix it yourself based on @dmethvin's suggestion.
Yes, that worked as I commented above, perhaps you can change that in the code of the official plugin?
Should be fixed as of 624c5ef