peek() method for BlockingReaderWriterCircularBuffer?

Question

peek() method for BlockingReaderWriterCircularBuffer?

f18m opened this issue a year ago · comments

Hi,
I'm trying to replace the ReaderWriterQueue with BlockingReaderWriterCircularBuffer (my idea is that with the latter I can remove some arbitrary sleep() calls in producer/consumer threads).
However I noticed that there is no such thing like ReaderWriterQueue::peek() defined in BlockingReaderWriterCircularBuffer. Is it possible to add such API or is there a good reason why it's missing?

Thanks!

Cameron · Answer 1 · Fri Feb 17 2023 07:54:26 GMT+0800 (China Standard Time)

I think it could be implemented. Depends whether items->availableApprox() being non zero guarantees an item is there, which I believe is the case.

Cameron · Answer 2 · Fri Feb 17 2023 07:56:34 GMT+0800 (China Standard Time)

Yeah, it would work because the consumer thread necessarily sees its own decrements on that semaphore, so if it sees the semaphore at non-zero, there must still actually be an element.

Cameron · Answer 3 · Fri Feb 17 2023 09:27:01 GMT+0800 (China Standard Time)

Added. Feel free to reopen if you find an issue with it.

Francesco Montorsi · Answer 4 · Fri Feb 17 2023 18:48:18 GMT+0800 (China Standard Time)

that was really fast, thanks a lot for the prompt response and implementation! will check it out ASAP