Bottom padding
zalmoxisus opened this issue · comments
Could you please publish changes to npm? The current 1.0.0 has bottom padding for the elements except slider bar, so it goes bellow the arrows (I guess it is because I don't use DockMonitor). It is fixed here, but not released yet.
I went ahead and published as 1.0.1. I'm still not happy with the layout, though, so I'll leave this issue open. I'll make sure to test without DockMonitor for future changes.
Hey @calesce,
I'm hacking some reusable components for building Redux DevTools monitors (specifically for the extension, but most of them will work for vanilla DevTools as well, except that they will use only the default theme there).
Here's a demo of the slider. From the right panel choose THEME, and you'll be able to change to default/material theme and color schemes.
Please let me know if you're still interested in maintaining and develop this repository further, have time to contribute, and find using my components suitable for Slider Monitor. If you want to keep it as is, I'll go with a separate one. Otherwise, I'd try to contribute it back.
In Redux DevTools Extension 3.0, apart from regular monitors, we'll have monitors for managing the reports, so if we move that part from remotedev-slider, we can deprecate it in favour of redux-slider-monitor. Again, the question is if you want to add additional complexity here.
Thanks @zalmoxisus, this looks great. What changes do you propose for this module? I'm interested in supporting DevTools Extension.
Except the UI, the most signifiant change, I guess, will be that instead of showing the current action id, we'll show action type (as slider label). I'll cut a beta of that lib in about a week and will submit a pr with implementation here.
👍 This does need UI enhancements, especially the slider handle.
instead of showing the current action id, we'll show action type (as slider label)
Maybe we can show both, or at least have it be configurable? I like being able to see total actions/index of current action.
The problem is that, due to using of maxAge, we don't have the real index and count of actions. We can show only the correct action id, though it's ambiguous, as the total number of actions we can time travel is not the same as the number of dispatched actions.
We have an option to see the slider value, but for our case we could show action id just in the parenthesis near the action type.
This does need UI enhancements, especially the slider handle.
If you meant the new slider, feel free to amend the css styles and send a pr, I don't see any issues with the handler there.
If you meant the new slider
No, I meant the one in this repo 😉 I much prefer the new slider's handle.