Invalid deprecation error for Date::startOfWeek()
jurchiks opened this issue · comments
Juris commented
I just updated my installation of Chronos to the latest available version for the project (PHP 7.3, so best I get is 2.4.4), and I got this nonsensical error:
(new Date($anyDateHere))->addWeeks(1)->startOfWeek()
throws
2.5 startOfDay() will be removed in 3.x.
But this method calls startOfDay()
implicitly, under the hood, users can't NOT call it.
othercorey commented
@markstory What do you think?
Marc Würth commented
startOfDay()
just does return $this->modify('midnight');
.
So why not do that where startOfDay()
is currently called?
Marc Würth commented
Same for endOfDay()
, by the way.