npm run lint errors.
aladdin-add opened this issue · comments
Care to fix it?
some stylistic issues can be easily fixed. I will open a PR later.😄
I'm not getting those errors.
I'm trying to replicate with npm run lint
npm run lint
I get nothing...
Oh. got it. seems like eslint read a config from my local.
the question is I didn't find a config in the repo. Did you forget to commit?
Indeed, I forgot to add it.
I usually just use standard.js
You care to change it to standard.js?
I think it's better to have its own config -- contributors may not using standard in their local.
opened a PR to fix it. #55
standard doesn’t have a config file.
That’s why I like it and usually use it on my projects.
…Sent from my iPhone
On July 19, 2017 at 10:36:39 AM, 薛定谔的猫 (notifications@github.com) wrote:
I think it's better to have its config own -- others may not using standard
in their local.
opened a PR to fix it. #55
<#55>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACBFOC8T4OL-nE8tzTkBGTXn3fPVMOsks5sPhR0gaJpZM4OadkV>
.
but seems like you are using eslint-config-standard, not standard. so also need a config.