`nirvana api` need to be compatible with `go mod`

Question

`nirvana api` need to be compatible with `go mod`

kdada opened this issue 5 years ago · comments

Wei Guo commented 5 years ago

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:

I created a nirvana project with go mod and the project is not in $GOPATH. nirvana api in this project failed with messages:

INFO  0320-11:49:45.516+08 api.go:87 | No packages are specified, defaults to pkg/apis
WARN  0320-11:49:45.516+08 builder.go:69 | can't find project file, instead by default config
FATAL 0320-11:49:45.516+08 api.go:61 | can't find descriptors from []

What you expected to happen:

Generate api as normal.

How to reproduce it (as minimally and precisely as possible):

Create a nirvana project in /tmp/myproject
Run nirvana api in /tmp/myproject

Anything else we need to know?:

API generator can't find correct packages because of the mechanism of go mod. The generator should use system relative path rather than packages from $GOPATH.

Zhizhen He commented 4 years ago

#299

Wei Guo · Answer 1 · Wed Mar 20 2019 14:32:50 GMT+0800 (China Standard Time)

/assign kdada

Deyuan Deng · Answer 2 · Thu Apr 09 2020 14:26:26 GMT+0800 (China Standard Time)

@kdada is this done?

Deyuan Deng · Answer 3 · Thu Apr 09 2020 14:26:33 GMT+0800 (China Standard Time)

/cc @iawia002

Jinming Yue · Answer 4 · Thu Apr 09 2020 19:42:26 GMT+0800 (China Standard Time)

#299 only switch to go mod for Nirvana, but it does not make nirvana api to support go mod. @hezhizhen

Zhizhen He · Answer 5 · Thu Apr 09 2020 20:24:28 GMT+0800 (China Standard Time)

#299 only switch to go mod for Nirvana, but it does not make nirvana api to support go mod. @hezhizhen

I mistook it for nirvana init