Engine should not call method from cyclone server
cd1989 opened this issue · comments
Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
Workflow Engine is lower level component of Cyclone, it should not be aware of Cyclone Server logic. So call method of Cyclone server is not allowed.
So this is not allowed:
What happened:
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Should also consider the common package, like https://github.com/caicloud/cyclone/blob/master/pkg/workflow/controller/handlers/workflowtrigger/cron_job.go#L20