cafejojo / schaapi

🐑 Safe Changes for APIs

Home Page:https://cafejojo.org/schaapi

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`JavaJarProjectCompiler` and `JavaMavenProjectCompiler` should log when a project is not a java and/or maven project

JSAbrahams opened this issue · comments

Currently, from what I understand from the implementation, the compilers take a JavaProject which has a directory which internally consists of .java files. These files are then converted to .class files by the compiler.

It however currently is not well defined what happens if it is not a java project. I would expect that the JarInputStream would return null when nextJarEntry is called. I'm not sure however if an exception is thrown or not.
Either way, it would be nice to log the fact that no .java files were made.

I noticed this when I was analysing the pipeline to see how it would integrate with the GitHub miner, which may or may not return Java maven projects.